sql: support ALTER DEFAULT PRIVILEGES for databases #153425
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
KeithCh
force-pushed
the
db-level-changefeed-default-privilege
branch
2 times, most recently
from
10c9407 to
11b358f
Compare
KeithCh
changed the title
KeithCh
force-pushed
the
db-level-changefeed-default-privilege
branch
from
11b358f to
4addf35
Compare
This will allow users to be ALTER DEFAULT privileges on all databases. The intent of this commit is to allow DEFAULT grants on changefeeds specifically i.e. ALTER DEFAULT PRIVILEGES GRANT CHANGEFEED ON DATABASES to foo; but I don't know how to do that without allowing other database privileges to be granted on all databases. Resolves: cockroachdb#152196 Release note: Users can now perform ALTER DEFAULT PRIVILEGES on DATABASES
KeithCh
force-pushed
the
db-level-changefeed-default-privilege
branch
from
4addf35 to
c71fec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to be ALTER DEFAULT privileges on all databases.
The intent of this commit is to allow DEFAULT grants on changefeeds
specifically i.e.
ALTER DEFAULT PRIVILEGES GRANT CHANGEFEED ON DATABASES to foo;
but I don't know how to do that without allowing other database
privileges to be granted on all databases.
Resolves: #152196
Release note: Users can now perform ALTER DEFAULT PRIVILEGES on DATABASES