Skip to content

Conversation

GekkeijuITA
Copy link

Refactored the UploadApiErrorResponse interface to nest error details under an 'error' object for improved type accuracy. Added a .gitattributes file to enforce LF line endings across the repository.

Brief Summary of Changes

  • Refactored the UploadApiErrorResponse interface to nest error details under an error object. This aligns the TypeScript type definition with the actual API response and the expectations of the existing test suite.
  • Added a .gitattributes file to the root of the repository to automatically enforce 'LF' line endings on all text files, resolving linting errors and ensuring consistency across different operating systems.

What Does This PR Address?

Are Tests Included?

  • Yes
  • No

Reviewer, Please Note:

  • The primary reason for this change is to resolve the inconsistency between the declared UploadApiErrorResponse interface and the actual error object returned by the API. The correction aligns the interface with the real behavior of the code, which is also confirmed by the passing of existing tests.
  • The addition of the .gitattributes file is a cleanup to ensure line ending consistency, which was causing linting issues during local testing.

Refactored the UploadApiErrorResponse interface to nest error details under an 'error' object for improved type accuracy. Added a .gitattributes file to enforce LF line endings across the repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant