User configuration via variables #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey cgfrost! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
Looks good to me though perhaps the |
|
How about using |
|
@jgawor Good point, I'll make that change. I'll update the example to show a bigger change as well. |
README.md
Outdated
There was a problem hiding this comment.
Which link? They are all working for me...
This commit adds support for overriding buildpack configuration with environment variables. The way Java config is processed has been modified to allow this new support to work when configuring the required version of Java. Includes new tests and documentation, see the main README.md for more details. [#86997400]
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for overriding buildpack configuration with
environment variables. The way Java config is processed has been
modified to allow this new support to work when configuring the
required version of Java. Includes new tests and documentation, see
the main README.md for more details.
[#86997400]