feat: containers ssh command
#10582
feat: containers ssh command
#10582
Conversation
🦋 Changeset detectedLatest commit: 22f6eff The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
| /* istanbul ignore file */ | ||
| /* tslint:disable */ | ||
| /* eslint-disable */ | ||
|
|
There was a problem hiding this comment.
Is this really needed?
If not, can this be removed from all the added files?
There was a problem hiding this comment.
this is all auto-generated code that's being copy-pasted over, we should remove these ignores but i can do that in a separate PR - its not really on @flakey5 :')
| /* istanbul ignore file */ | ||
| /* tslint:disable */ | ||
| /* eslint-disable */ | ||
|
|
There was a problem hiding this comment.
this is all auto-generated code that's being copy-pasted over, we should remove these ignores but i can do that in a separate PR - its not really on @flakey5 :')
| resolve(undefined); | ||
| } else { | ||
| reject( | ||
| new Error(`ssh exited unsuccessfully. Is the container running?`) |
There was a problem hiding this comment.
what should the user do if the container isn't running?
There was a problem hiding this comment.
They should start it themselves, we want to avoid starting it for them here since we don't actually know what the container is doing (ex/ containers that create backups, cleanup tasks, ...)
|
This PR is a requirement for SSH for containers After this is merged, we will update this PR |
Wrangler PR: cloudflare/workers-sdk#10582 Signed-off-by: flakey5 <[email protected]>
Wrangler PR: cloudflare/workers-sdk#10582 Signed-off-by: flakey5 <[email protected]>
| ); | ||
| } | ||
|
|
||
| if (key.public_key.toLowerCase().startsWith("ssh-ed25519")) { |
There was a problem hiding this comment.
Not sure if we wanna have this check here, it's not unlikely that we end up supporting more key types and this would make it so you'd need to update wrangler in order to use them
Closes CC-4634 Signed-off-by: flakey5 <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Co-authored-by: emily-shen <[email protected]> Co-authored-by: Victor Berchet <[email protected]>
Co-authored-by: emily-shen <[email protected]>
emily-shen
force-pushed
the
flakey5/cc-4634
branch
from
feedecb to
22f6eff
Compare
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
Closes CC-4634
Adds a
containers sshcommand +sshandauthorized_keysproperties to a container's configuration. This allows for ssh'ing into a container through wrangler.