Skip to content

Conversation

Dreaming-Codes
Copy link
Contributor

No description provided.

@guybedford
Copy link
Collaborator

Thanks for this! I'm still trying to pick up on the context of how this ever got disabled in the first place, and to track down that we always enable it.

@guybedford
Copy link
Collaborator

Seems this is just failing some unrelated clippy formatting fixes.

@lukevalenta
Copy link
Contributor

lukevalenta commented Jul 7, 2025

I'm planning to push another commit to #763 shortly to fix the clippy lint issues.

EDIT: Tests are now passing for #763. Feel free to cherry-pick those changes as needed!

@guybedford guybedford merged commit c39a132 into cloudflare:main Jul 8, 2025
3 checks passed
lukevalenta added a commit to cloudflare/azul that referenced this pull request Jul 11, 2025
* Update wrangler KV and R2 resources for MTC dev deploy
* Re-enable wasm-opt (see cloudflare/workers-rs#767)
lukevalenta added a commit to cloudflare/azul that referenced this pull request Jul 14, 2025
* Add support for MTC's initial log entry

In MTCs, the certificate serial number is its index in the log. Since
X.509 serial numbers must be non-zero, MTCs adds an initial 'null_entry'
at index 0 to help avoid off-by-one errors in consumers of the log.

* Add support for parsing the log ID as a ObjectIdentifier

This is not compatibile with the current MTC draft which uses RELATIVE-OID, but will do until RustCrypto/formats#1875 is handled.

* Rename Signature -> NoteSignature to avoid naming conflicts

* Clean up config

* Update wrangler KV and R2 resources for MTC dev deploy
* Re-enable wasm-opt (see cloudflare/workers-rs#767)

* Add cosignature support

Add support for cosignature/v1 signatures from tlog-cosignature
Add support for subtree_signatures from current MTC draft.  This is
  currently limited to signing checkpoints but not arbitrary subtrees.

Other changes (hopefully improvements):
- Consolidate signed_note error types into NoteError
- Add new() functions for Ed25519NoteSigner/Verifier to avoid needing to go through text format
- Add KeyName wrapper around string that enforces that key names are valid according to signed_note spec
- Move Ed25519 signer/verifier to separate file in signed_note
- Add enum for signed_note signature types

* Make kv_namespaces optional when enable_dedup = false

Previously, when enable_dedup was set to false, entries were still written to the long-term deduplication cache in KV. Now, deduplication is skipped entirely.

* Document how to reset a targeted dev log without needing to clear DO storage and R2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants