Add name method to ObjectId, fixes #760 #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix up worker-sandbox/wrangler.toml to get 'npx wrangler dev' to work (on macOS) - Add SOME_SECRET to .dev.vars to fix /durable/:id endpoint - Add handlers for /hello and /storage endpoints in export_durable_object.rs in order to test ObjectId::name()
1 task
lukevalenta
commented
Jun 20, 2025
Merged
lukevalenta
commented
Jun 23, 2025
guybedford
reviewed
Jun 23, 2025
guybedford
previously approved these changes
Jun 23, 2025
lukevalenta
commented
Jun 23, 2025
guybedford
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to add more tests, etc. if you point me in the right direction. Running
npx wrangler devfrom worker-sandbox (with the fixes from this PR), I get the following outputs as expected: