MS Entra Workload Identities implementation #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/config_test.go
Outdated
|
|
||
| require.True(t, cfg.UseEphemeralStorage, "UseEphemeralStorage is not as expected") | ||
| require.Equal(t, "10.10.0.0/24", cfg.VirtualNetworkCIDR, "VirtualNetworkCIDR is not as expected") | ||
| require.Equal(t, "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg-Network/providers/Microsoft.Network/virtualNetworks/vnet-Default/subnets/snet-default", cfg.VnetSubnetID, "VnetSubnetID is not as expected") | ||
| require.True(t, cfg.UseAcceleratedNetworking, "UseAcceleratedNetworking is not as expected") | ||
| require.True(t, cfg.DisableIsolatedNetworks, "DisableIsolatedNetworks is not as expected") | ||
| } | ||
|
|
||
| func TestAbsentTokenFile(t *testing.T) { | ||
| mockData := ` |
There was a problem hiding this comment.
if it's easier, you can actually use the file in the testdata folder. That config.toml serves as an example, but also as a valid test config file. You can also add more config.toml files with various settings for testing.
More details on using testdata: https://tutorialedge.net/golang/advanced-go-testing-tutorial/#use-the-testdata-directory
| TenantID string `toml:"tenant_id"` | ||
| ClientID string `toml:"client_id"` | ||
| FederatedTokenFile string `toml:"federated_token_file"` | ||
| // AuthorityHost is not handled yet. |
There was a problem hiding this comment.
If we don't need this now, we can just remove the commented code and add it later.
gabriel-samfira
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ability to authenticate over Azure using Workload Identity workflow.
This workflow is needed for example if garm is deployed inside an AKS (Azure managed kubernetes cluster), where a User Assigned identity or a System managed identity cannot be used.