Linking problem with redisserversample

[marcosszydlo]

I would like to try out libjson-rpc-cpp. I am using Red Hat 7, so I pulled the project from github and I am following the instructions to build it. Everything compiles, but I am running into the following link error:

[ 66%] Linking CXX executable ../../bin/redisserversample
../../lib/libjsonrpccpp-server.so.1.0.0: undefined reference to pthread_create' ../../lib/libjsonrpccpp-server.so.1.0.0: undefined reference to pthread_join'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/redisserversample] Error 1
make[1]: *** [src/examples/CMakeFiles/redisserversample.dir/all] Error 2
make: *** [all] Error 2

Do you have any suggestions as to how to proceed?

Thanks,
Marcos

[marcosszydlo]

I was able to solve the problem by adding -pthread at the end of the command line in redisserversample.dir/link.txt. I ran into a similar problem again and fixed it for filedescriptorserversample.dir/link.txt the same way. But these files are built by cmake. Shouldn't the generated files already include the -pthread option?

The next error I am encountering is:
[ 93%] Building CXX object src/test/CMakeFiles/unit_testsuite.dir/test_integration.cpp.o
/afs/mitll/usr/MA28351/repos/libjson-rpc-cpp/src/test/test_integration.cpp: In function \u2018void ____C_A_T_C_H____T_E_S_T____0()\u2019:
/afs/mitll/usr/MA28351/repos/libjson-rpc-cpp/src/test/test_integration.cpp:143:13: error: \u2018pipe\u2019 was not declared in this scope
pipe(c2sfd);
^
/afs/mitll/usr/MA28351/repos/libjson-rpc-cpp/src/test/test_integration.cpp:166:17: error: \u2018close\u2019 was not declared in this scope
close(c2sfd[0]);
^
make[2]: *** [src/test/CMakeFiles/unit_testsuite.dir/test_integration.cpp.o] Error 1
make[1]: *** [src/test/CMakeFiles/unit_testsuite.dir/all] Error 2
make: *** [all] Error 2

Any suggestions?

[marcosszydlo]

I was able to close all my issues. It appears the latest code has not been built tested on Linux:

• Several of the generated link.txt files are missing the flag "-pthread"
• the test_integration.cpp file was missing #include <unistd.h>. Without that include the Linux calls pipe() and close() could not be resolved

After solving all these issues the whole code builds.

I'll be happy to submit the change to test_integration.cpp. I don't know enough of CMake to know where to change the generating files that build the link.txt files that are missing the pthread flag.

In any case, I'll now go and play with the code.

Thanks,
Marcos

[cinemast]

Could you prepare a PullRequest for that?

[marcosszydlo]

I was able to figure out the problem with CMake. The following line was missing in CMakeDependencies.cmake:

find_package(Threads REQUIRED)

Now, the whole package builds in RedHat REL 7 (which is what I'm using).
I could prepare a PullRequest for all these issues, but have some questions:
Do I need to create a fork before issuing the PullRequest? Or can I just create a new branch and use the shared model?

Thanks,
Marcos

[cinemast]

Thanks!