(#669) Add version completion for install and upgrade commands #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
PROJ-1501_PowerShell-tab-completion-option-filter-improvements_Kim-Nordmo
branch
2 times, most recently
from
d9257e3 to
2c55b69
Compare
10 tasks
corbob
reviewed
Jun 30, 2025
AdmiringWorm
force-pushed
the
PROJ-1501_PowerShell-tab-completion-option-filter-improvements_Kim-Nordmo
branch
2 times, most recently
from
92e322e to
6817ac3
Compare
|
@AdmiringWorm is this still in draft, or is this ready for review? |
It is still in draft, waiting on the test kitchen to finish. |
AdmiringWorm
force-pushed
the
PROJ-1501_PowerShell-tab-completion-option-filter-improvements_Kim-Nordmo
branch
from
d65d88f to
a7c35a4
Compare
|
@gep13 I have opened this for review now, it succeeded internally on the 2016 image, but failed to spin up the 2019 image (but since it succeeded on one of them, I think it is fine). |
Add chocoRemotePackageVersions function to fetch package versions from remote source and integrate it into tab completion for install and upgrade commands with --version option. This enables listing of available versions for a specified package, improving user experience when specifying versions. Add Pester tests to verify version completions appear correctly for various --version input scenarios and cursor positions, ensuring reliable behavior.
Modify GetSortOrder to accept an outputWarnings parameter that controls whether client-side ordering warnings are logged. This prevents unwanted warnings when output is suppressed, improving user experience during quiet or non-regular output scenarios. Update all callers accordingly.
gep13
force-pushed
the
PROJ-1501_PowerShell-tab-completion-option-filter-improvements_Kim-Nordmo
branch
from
a7c35a4 to
d8f44f0
Compare
|
@AdmiringWorm this looks great! Thank you for taking the time to get this added! This will be a big help going forward! |
AdmiringWorm
deleted the
PROJ-1501_PowerShell-tab-completion-option-filter-improvements_Kim-Nordmo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Enhances PowerShell tab completion for Chocolatey
installandupgradecommands by dynamically listing available--versionvalues for a specified package. Specifically:chocoRemotePackageVersionshelper function to query all available versions for a given package viachoco search.ChocolateyTabExpansionto detect version requests and emit completions using a match on partial version input.--versionvalues.2returns only 2.x).Motivation and Context
Users installing or upgrading packages via Chocolatey sometimes need to specify a version manually. Without completions, this requires knowing exact version strings in advance. This change improves usability by providing context-aware completions for the
--versionparameter based on available versions from the remote source. It also adds comprehensive tests to verify correctness and edge case behavior.Testing
choco installandchoco upgradeusing various--versioninputs. (--version=,--version='and--version=''. Latest need to have the cursor between the single quotes).Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
ChocolateyTabExpansion.ps1file with completions for multiple Chocolatey CLI commands #669