Skip to content

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This updates the version used in the GitHub workflows to be a version
of upload-artifact that does not throw an exception.

Motivation and Context

The current version we are using started throwing an exception yesterday
due to it no longer being recommended to be used.

So to be able to continue building through the GitHub workflows, we must update this dependency.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

This updates the version used in the GitHub workflows to be a version
of upload-artifact that does not throw an exception.

The current version we are using started throwing an exception yesterday
due to it no longer being recommended to be used.
@AdmiringWorm AdmiringWorm self-assigned this Jan 31, 2025
@AdmiringWorm AdmiringWorm requested a review from gep13 January 31, 2025 14:46
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 9c92c60 into chocolatey:develop Jan 31, 2025
5 checks passed
@gep13
Copy link
Member

gep13 commented Jan 31, 2025

@AdmiringWorm thanks for getting this updated!

AdmiringWorm pushed a commit that referenced this pull request Jan 31, 2025
(maint) Update version for upload-artifact

(cherry picked from commit 9c92c60)
@AdmiringWorm AdmiringWorm deleted the bump-artifact-deps branch January 31, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants