fix(fixRequestBody): support content-encoding on request body #1142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The body-parser package supports the
content-encoding
header on the request (See here). When reconstructing the body for proxied requests that have already been parsed, we should respect thecontent-encoding
header and preserve the original compression algorithm.Motivation and Context
Without this patch, an encoded request will fail when the upstream server attempts to read it due to a mismatch between the compression algorithm reported and the actual payload received. An alternative approach would be to remove the
content-encoding
header from the proxied request, but this seems more appropriate.How has this been tested?
I added a unit test to verify that the reconstructed body is encoded as expected.
Types of changes
Checklist: