-
Notifications
You must be signed in to change notification settings - Fork 8
fix: update go clean usage for newer Go versions #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Compatible with the old version (1.18) too.
WalkthroughThe Makefile's test target was updated by splitting the previous combined test cache and build artifact cleaning command into two separate commands: one for clearing the test cache globally and another for cleaning build artifacts across all packages. No changes were made to exported or public entities. Changes
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Makefile (1)
1-6
: Declare targets as.PHONY
to avoid name-shadowingIt’s common to add a
.PHONY
declaration so the targets don’t get skipped when files namedtest
,demo
, orfmt
appear in the repo.+ .PHONY: test demo fmt
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Makefile
(1 hunks)
🔇 Additional comments (1)
Makefile (1)
2-3
: Split clean commands correctly for Go ≥1.20 — looks good
go clean -testcache
(no patterns) is now the only form accepted by Go 1.20+, whilego clean ./...
preserves the full-package clean for 1.18. The two‐line split keeps both versions happy and has no side effects.Nothing else to flag here. 👍
Compatible with the old version (1.18) too.
Affected Components
Style
go fmt
Notes for the Reviewer
New Dependency Submission