-
Notifications
You must be signed in to change notification settings - Fork 7
Fixes getStaticIPs #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes getStaticIPs #133
Conversation
WalkthroughThe changes update the handling of IPv6 static IPs in the codebase and its associated test fixture. The code now expects each region to provide a list of IPv6 CIDR strings, rather than a single string per region. The fixture JSON structure is updated to match this new format. Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thanks, I'll look at this shortly 👍 |
It looks like this broke around June 16th. The new format is more correct than the old one, but it was definitely a breaking change. |
This should be available shortly in TF provider v1.11.1 which is being released right now. |
Affected Components
Style
go fmt
Notes for the Reviewer
FIxes
json: cannot unmarshal array into Go value of type string
currently observed in theGetStaticIPs
method./v1/static-ipv6s-by-region
was historically a map with string values but was changed at some point to be a string array; this updates the go client to reflect that change.If a corresponding Terraform provider version could be published on the back of this that would be great, as that's where we're personally impacted by the issue