assert.hasAllKeys incorrectly assumes expected keys do not contain duplicates

[madx]

While writing a test using assert.hasAllKeys, I encountered an issue when the array of expected keys contains a duplicate. The following code demonstrates the bug:

test('hasAllKeys', () => {
  assert.hasAllKeys({ a: 1, b: 2 }, ['a', 'a'])
})
// => test passes

I expect this test to fail because of the presence of b, but it actually passes when running the test suite. It might seem like having a duplicate is unlikely, but that is something that can happen when you quickly want to swap a value to make sure that the test fails with the wrong set of keys. I also think that the current semantics are a bit misleading when compared to the documentation of the hasAllKeys function.

I think I found the incriminated code and am willing to submit a PR to fix the issue if that is something that you would consider. The second part of the block should instead check that every key in actual is also present in expected. This will add a small computation cost as it will require another double loop. Another way to do it would be to keep only unique values in expected.

Environment: ArchLinux, vitest 3.2.4

[43081j]

i wonder if we can just use a Set here:

chai/lib/chai/core/assertions.js

Line 2534 in c22027c

expected = keys,

i.e.

expected = keys,
expectedUnique = [...new Set(keys)],

keep the original expected as it is now since it gets used later on for error messages etc