467 shared hosting text #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wioux
reviewed
Feb 26, 2020
hosting_providers/index.md
Outdated
| <h3>This page is for users of {% include tooltip.html term-name="shared-hosting" text="shared hosting" %}.</h3> | ||
| <br> | ||
|
|
||
| If you're not using the shared hosting product, or if your provider doesn't appear here, check out our <a href="/instructions">instructions</a> for using Certbot or <a href="/help">get help</a>. Note that your {% include tooltip.html term-name="shared-hosting" text="shared hosting provider" %} is not the same as your {% include tooltip.html term-name="domain-registrar" text="domain registrar" %}. |
There was a problem hiding this comment.
What do you think about nixing the second glossary link for shared-hosting?
This branch LGTM anyway, but I think it would improve the readability of this paragraph. The term is already boldly glossary-linked right before here.
There was a problem hiding this comment.
I think it'd be useful to include the sentence "Note that your shared hosting provider
is not the same as your domain registrar.", without re-highlighting "shared hosting". Lots of newbies conflate the two.
There was a problem hiding this comment.
I just mean not making the second use of the term link to the glossary again.
wioux
previously approved these changes
Mar 2, 2020
wioux
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #467