Skip to content

Rename ViewPagerAndroid to ViewPager #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

Rename ViewPagerAndroid to ViewPager #64

merged 1 commit into from
Oct 7, 2019

Conversation

troZee
Copy link
Collaborator

@troZee troZee commented Oct 5, 2019 •
edited
Loading

Summary

Now lib supports both platforms, so the name should be unified.

Test Plan

Just run on device

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator

@ferrannp ferrannp self-requested a review October 5, 2019 20:40
@devvit devvit mentioned this pull request Oct 6, 2019
Closed
@ferrannp ferrannp merged commit b983027 into master Oct 7, 2019
@ferrannp ferrannp deleted the troZee/rename-to-viewpager branch October 7, 2019 08:41
@jimmyltsinn jimmyltsinn mentioned this pull request Nov 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrannp ferrannp Awaiting requested review from ferrannp

2 more reviewers

@dratwas dratwas dratwas approved these changes

@osdnk osdnk osdnk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@troZee @dratwas @osdnk @ferrannp