Add imported functions callback samples #4606
Open
+274
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylo5aby
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
yamt
reviewed
Sep 8, 2025
lum1n0us
added
the
enhancement
kylo5aby
force-pushed
the
import-callback
branch
2 times, most recently
from
bd8d4ae to
a3578eb
Compare
lum1n0us
reviewed
Sep 10, 2025
| cd build | ||
| cmake .. | ||
| make | ||
| ``` |
There was a problem hiding this comment.
Need a section on how to run. Additionally, I believe we can simplify the execution by removing those options.
| target_link_libraries (import-func-callback vmlib -lm -ldl -lpthread ${LLVM_AVAILABLE_LIBS}) | ||
| else () | ||
| target_link_libraries (import-func-callback vmlib -lm -ldl -lpthread -lrt ${LLVM_AVAILABLE_LIBS}) | ||
| endif () |
There was a problem hiding this comment.
Missing CMake to generate Wasm.
kylo5aby
force-pushed
the
import-callback
branch
3 times, most recently
from
ab0d448 to
500e809
Compare
|
the ci failure doesn't seem like a fault of this PR. |
lum1n0us
reviewed
Sep 11, 2025
core/iwasm/include/wasm_export.h
Outdated
| @@ -1526,6 +1526,8 @@ wasm_runtime_get_native_addr_range(wasm_module_inst_t module_inst, | |||
| /** | |||
| * Get the number of import items for a WASM module | |||
| * | |||
| * Example usage (as shown in samples/import-func-callback) | |||
There was a problem hiding this comment.
maybe,
Suggested change
| * Example usage (as shown in samples/import-func-callback) | |
| * Example usage (as wasm_runtime_for_each_import_func() in samples/import-func-callback) |
There was a problem hiding this comment.
maybe,
resolved. thanks
kylo5aby
force-pushed
the
import-callback
branch
from
500e809 to
236ea1f
Compare
kylo5aby
changed the title
lum1n0us
approved these changes
Sep 14, 2025
TianlongLiang
approved these changes
Sep 15, 2025
|
can you rebase after #4620? |
Signed-off-by: zhenweijin <[email protected]>
kylo5aby
force-pushed
the
import-callback
branch
from
236ea1f to
f4f6c4a
Compare
resolved. I see some tests failed STDERR:
thread 'main' panicked at 'expected errno NOENT; got NOTDIR', src/bin/path_symlink_trailing_slashes.rs:7:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtracethat maybe a github action CI Windows env error. |
|
yamt
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios that require permission control, users may want to know if a Wasm app has the authority to use the native APIs it's about to import. To address this, we've added a callback that executes when the Wasm module loads an imported function.