Fix compilation error when MSVC is not set to C11 standard #4588
Conversation
vkensou
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
| @@ -29,6 +29,9 @@ | |||
| #endif /* _Alignof */ | |||
|
|
|||
| extern "C" { | |||
| #elif defined(_MSC_VER) && !_CRT_HAS_C11 | |||
| #define _Static_assert static_assert | |||
| #define _Alignof __alignof | |||
There was a problem hiding this comment.
IMM, how about?
#ifdef __cplusplus
extern "C" {
#endif
#ifndef _Static_assert
#define _Static_assert static_assert
#endif /* _Static_assert */
#ifndef _Alignof
#if defined(_MSC_VER) && !_CRT_HAS_C11
#define _Alignof __alignof
#else
#define _Alignof alignof
#endif
#endif /* _Alignof */There was a problem hiding this comment.
This make a lot error. So I revert it.
There was a problem hiding this comment.
May I ask about the error? the modification I apologize for the confusion. My intention is to expand the compatibility of _Static_assert and _Align_of.
As far as I know, if __cplusplus >= 201103L, static_assert is a keyword. if __STDC_VERSION__ >= 201112L, _Static_assert is a keyword. Both __GNUC__ and __clang__ support _Static_assert since version 4.6, and if _MSC_VER >= 1600 supports _Static_assert for both C++ and C.
Therefore, we might need to reorganize to cover all these cases.
There was a problem hiding this comment.
errors are here: https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/17377924957/job/49328417065
I am not familiar with gcc/clang. Seems gcc and clang is ok when use c99. Only msvc must use c11.
lum1n0us
added
the
bug-fix
This reverts commit bd15116.
No description provided.