Skip to content

fix: we never remove fds that want deletion #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: we never remove fds that want deletion #1383

merged 1 commit into from
Feb 20, 2025

Conversation

braindigitalis
Copy link
Contributor

fix oof.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Feb 20, 2025
@github-actions github-actions bot closed this Feb 20, 2025
@github-actions github-actions bot added the code Improvements or additions to code. label Feb 20, 2025
@braindigitalis braindigitalis changed the base branch from master to dev February 20, 2025 18:58
@brainboxdotcc brainboxdotcc deleted a comment from github-actions bot Feb 20, 2025
RealTimeChris
RealTimeChris approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@RealTimeChris RealTimeChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@braindigitalis braindigitalis merged commit 0fedcdd into dev Feb 20, 2025
103 of 124 checks passed
@braindigitalis braindigitalis deleted the poll_fixes branch February 20, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealTimeChris RealTimeChris RealTimeChris approved these changes

@Mishura4 Mishura4 Awaiting requested review from Mishura4

@Jaskowicz1 Jaskowicz1 Awaiting requested review from Jaskowicz1

Assignees

@braindigitalis braindigitalis

Labels
code Improvements or additions to code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braindigitalis @RealTimeChris