Skip to content

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Feb 19, 2025

This PR adds support for Discord's new Components V2, due for release in March.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Documentation change checklist

  • My documentation changes follow the docs style guide and any code examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

@braindigitalis braindigitalis self-assigned this Feb 19, 2025
@braindigitalis braindigitalis added documentation Improvements or additions to documentation enhancement New feature or request code Improvements or additions to code. labels Feb 19, 2025
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 1d9f960
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67b60a95f174540008af8321
😎 Deploy Preview https://deploy-preview-1381--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis marked this pull request as ready for review February 19, 2025 16:39
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constexpr std::array with std::find would be a lot better than std::set for this amount of values but I won't block the PR on this

@braindigitalis braindigitalis merged commit fb48e97 into dev Feb 19, 2025
51 checks passed
@braindigitalis braindigitalis deleted the components_v2 branch February 20, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants