Skip to content

Explicitly rollback when transaction commit fails #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Explicitly rollback when transaction commit fails #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75861ee
Explicitly rollback when transaction commit fails
Bixilon Mar 16, 2025
d8180be
fix fmt linting
Bixilon Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/queryable/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,26 @@ impl<'a> Transaction<'a> {
Ok(Transaction(conn))
}

/// Performs `COMMIT` query.
pub async fn commit(mut self) -> Result<()> {
/// Performs `COMMIT` query or returns an error
async fn try_commit(&mut self) -> Result<()> {
let result = self.0.query_iter("COMMIT").await?;
result.drop_result().await?;
self.0.set_tx_status(TxStatus::None);
Ok(())
}

/// Performs `COMMIT` query or rollbacks when any error occurs and returns the original error.
pub async fn commit(mut self) -> Result<()> {
match self.try_commit().await {
Ok(..) => Ok(()),
Err(e) => {
self.0.query_drop("ROLLBACK").await.unwrap_or(());
self.0.set_tx_status(TxStatus::None);
Err(e)
}
}
}

/// Performs `ROLLBACK` query.
pub async fn rollback(mut self) -> Result<()> {
let result = self.0.query_iter("ROLLBACK").await?;
Expand Down
Loading