Cache the TlsConnector built from SslOpts #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing a TlsConnector is fairly expensive - it can involve searching for and parsing certificates, for example.
Both native-tls and rustls therefore allow a single TlsConnector to be used to connect many times.
To avoid adding a fallible (and async) initialization step and therefore preserve the public API of this crate, this PR caches the TlsConnector beside the SslOpts using a tokio OnceCell, so that any error from its construction still gets emitted at the same point.
The SslOpts and corresponding TlsConnector are stored together in a struct in order to avoid accidentally mutating the SslOpts without clearing the connector.
I've also slightly refactored the no-TLS case to behave more uniformly with the rustls and native-tls implementations.