Allow overriding domain used for TLS hostname verification #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks for whipping this up, @rjobanp!
@blackbeam—hopefully this is something that other users of mysql_async might find useful too. Would be a big help for us at @MaterializeInc!
rjobanp
force-pushed
the
tls-domain-override
branch
from
9776af0 to
d78dfde
Compare
5 tasks
|
@blackbeam thank you for reviewing and merging my PRs into this repo and mysql-common! Do you plan to cut a new release for both crates soon? Thanks again! |
convex-copybara bot
referenced
this pull request
in get-convex/convex-backend
Jul 4, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mysql_async](https://togithub.com/blackbeam/mysql_async) | workspace.dependencies | minor | `0.33.0` -> `0.34.0` | --- ### Release Notes <details> <summary>blackbeam/mysql_async (mysql_async)</summary> ### [`v0.34.1`](https://togithub.com/blackbeam/mysql_async/releases/tag/v0.34.1) [Compare Source](https://togithub.com/blackbeam/mysql_async/compare/v0.34.0...v0.34.1) #### What's Changed - Fix imports for non-default features by [@​blackbeam](https://togithub.com/blackbeam) in [https://github.com/blackbeam/mysql_async/pull/299](https://togithub.com/blackbeam/mysql_async/pull/299) **Full Changelog**: blackbeam/mysql_async@v0.34.0...v0.34.1 ### [`v0.34.0`](https://togithub.com/blackbeam/mysql_async/releases/tag/v0.34.0) [Compare Source](https://togithub.com/blackbeam/mysql_async/compare/v0.33.0...v0.34.0) #### What's Changed - Use an explicit priority check by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/271](https://togithub.com/blackbeam/mysql_async/pull/271) - Refactor pool creation in tests by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/268](https://togithub.com/blackbeam/mysql_async/pull/268) - Implement Borrow<QueueId> for QueuedWaker by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/266](https://togithub.com/blackbeam/mysql_async/pull/266) - Inline poll_new_conn_inner into only caller by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/267](https://togithub.com/blackbeam/mysql_async/pull/267) - Make queue_id non-optional by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/273](https://togithub.com/blackbeam/mysql_async/pull/273) - Drop unnecessary use of Pin by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/277](https://togithub.com/blackbeam/mysql_async/pull/277) - Silence clippy warnings by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/276](https://togithub.com/blackbeam/mysql_async/pull/276) - Always save the most recent waker by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/272](https://togithub.com/blackbeam/mysql_async/pull/272) - Delete GetConnInner::take by [@​espindola](https://togithub.com/espindola) in [https://github.com/blackbeam/mysql_async/pull/279](https://togithub.com/blackbeam/mysql_async/pull/279) - fix skip_domain_validation usage when using rustls by [@​alekitto](https://togithub.com/alekitto) in [https://github.com/blackbeam/mysql_async/pull/284](https://togithub.com/blackbeam/mysql_async/pull/284) - annotate `Transaction` with `must_use` by [@​petrosagg](https://togithub.com/petrosagg) in [https://github.com/blackbeam/mysql_async/pull/290](https://togithub.com/blackbeam/mysql_async/pull/290) - Allow specifying root certs and Client Identity as bytes rather than via a file by [@​blackbeam](https://togithub.com/blackbeam) in [https://github.com/blackbeam/mysql_async/pull/291](https://togithub.com/blackbeam/mysql_async/pull/291) - Allow specifying root certs and Client Identity \[for native-tls] as bytes rather than via a file by [@​rjobanp](https://togithub.com/rjobanp) in [https://github.com/blackbeam/mysql_async/pull/288](https://togithub.com/blackbeam/mysql_async/pull/288) - Allow overriding domain used for TLS hostname verification by [@​blackbeam](https://togithub.com/blackbeam) in [https://github.com/blackbeam/mysql_async/pull/292](https://togithub.com/blackbeam/mysql_async/pull/292) - Allow overriding domain used for TLS hostname verification by [@​rjobanp](https://togithub.com/rjobanp) in [https://github.com/blackbeam/mysql_async/pull/289](https://togithub.com/blackbeam/mysql_async/pull/289) - Use DROP USER in test by [@​grooverdan](https://togithub.com/grooverdan) in [https://github.com/blackbeam/mysql_async/pull/295](https://togithub.com/blackbeam/mysql_async/pull/295) - proxy `mysql_common` features by [@​blackbeam](https://togithub.com/blackbeam) in [https://github.com/blackbeam/mysql_async/pull/297](https://togithub.com/blackbeam/mysql_async/pull/297) #### New Contributors - [@​espindola](https://togithub.com/espindola) made their first contribution in [https://github.com/blackbeam/mysql_async/pull/271](https://togithub.com/blackbeam/mysql_async/pull/271) - [@​alekitto](https://togithub.com/alekitto) made their first contribution in [https://github.com/blackbeam/mysql_async/pull/284](https://togithub.com/blackbeam/mysql_async/pull/284) - [@​petrosagg](https://togithub.com/petrosagg) made their first contribution in [https://github.com/blackbeam/mysql_async/pull/290](https://togithub.com/blackbeam/mysql_async/pull/290) - [@​rjobanp](https://togithub.com/rjobanp) made their first contribution in [https://github.com/blackbeam/mysql_async/pull/288](https://togithub.com/blackbeam/mysql_async/pull/288) - [@​grooverdan](https://togithub.com/grooverdan) made their first contribution in [https://github.com/blackbeam/mysql_async/pull/295](https://togithub.com/blackbeam/mysql_async/pull/295) **Full Changelog**: blackbeam/mysql_async@v0.33.0...v0.34.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on the first day of the month" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/get-convex/convex). GitOrigin-RevId: 6509626c78732e9f033417b4c3c47faab9a00e4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for specifying an alternate domain name for TLS hostname verification, which is useful in a scenario where the mysql connection is being tunneled and the connection host and remote server host are different.
Thanks!