Skip to content

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Sep 8, 2025

🎟️ Tracking

PM-24773

📔 Objective

Adding conditional for the subject name and the button text on the invite user email.

📸 Screenshots

New User:
image

Existing User:
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.83%. Comparing base (aab50ef) to head (a7e28d4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...re/Models/Mail/OrganizationUserInvitedViewModel.cs 3.22% 30 Missing ⚠️
.../Services/Implementations/HandlebarsMailService.cs 50.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6304      +/-   ##
==========================================
- Coverage   49.86%   49.83%   -0.03%     
==========================================
  Files        1824     1824              
  Lines       80917    80954      +37     
  Branches     7180     7182       +2     
==========================================
- Hits        40346    40341       -5     
- Misses      39015    39055      +40     
- Partials     1556     1558       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Sep 8, 2025

Logo
Checkmarx One – Scan Summary & Detailse939a773-73d2-41b2-921c-a0a4e5ccd016

New Issues (5)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1001
detailsMethod at line 1001 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
ID: L%2F7kdqzKH3JeOPXiLG6Q%2Fw6DyKg%3D
Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 932
detailsMethod at line 932 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows t...
ID: Tpp6ijdEJh%2BPun415z%2B2V7W8ZFQ%3D
Attack Vector
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 412
detailsMethod at line 412 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
ID: %2FMmuua5ut7PaW0XHxQvGVyEFxn0%3D
Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1334
detailsMethod at line 1334 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
ID: 2aBmc4meYv9ptMVbRWSxoFNwT8s%3D
Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1214
detailsMethod at line 1214 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
ID: S4U1zMBH5CBlzxdNqZoHeA22Itg%3D
Attack Vector
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 281

@jrmccannon jrmccannon marked this pull request as ready for review September 9, 2025 19:47
@jrmccannon jrmccannon requested a review from a team as a code owner September 9, 2025 19:47
@jrmccannon jrmccannon requested a review from JimmyVo16 September 9, 2025 19:47
@jrmccannon jrmccannon marked this pull request as draft September 10, 2025 20:54
JimmyVo16
JimmyVo16 previously approved these changes Sep 11, 2025
Copy link

@jrmccannon jrmccannon marked this pull request as ready for review September 11, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants