-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Switch to using built in source link feature #6297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6297 +/- ##
==========================================
- Coverage 49.51% 49.49% -0.02%
==========================================
Files 1783 1783
Lines 79374 79375 +1
Branches 7054 7055 +1
==========================================
- Hits 39299 39289 -10
- Misses 38544 38551 +7
- Partials 1531 1535 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some safety in case we're not in a Git repo or have other limitations.
Co-authored-by: Matt Bishop <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding from a phone 😬 ... 😜
|
🎟️ Tracking
📔 Objective
We introduced including the git hash in our config endpoint before .NET 8 but in .NET 8 this became built in, albeit with a different format than we had used. This removes out opt out and deletes our home grown solution. This has the awesome side effect of cleaning up the built output a good amount.
https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link
The format that is used by the built in solution is:
2025.8.1+b7200837c3835c005ec3ae6a45b4a3ffa42d1c38
so to get the same information as we were getting before we split by a+
. Take the first bit as the version and slice off the second part to only 8 characters.In order to make unit testing this more possible and to make it more guarunteed to return a value instead of
null
I switched to usingtypeof(AssemblyHelpers).Assembly
to get the assembly instead ofAssembly.GetEntryAssembly()
the behavior change is that we will be getting the information out of theCore
assembly instead of whichever assembly was started likeApi
,Admin
, orIdentity
but sinceCore
is also a local dependency and not consumed via a nuget package or something the values should always be equal.Before:
After:

📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes