Skip to content

Conversation

bensbits91
Copy link

@bensbits91 bensbits91 commented Sep 5, 2025

🎟️ Tracking

PM-19310

📔 Objective

New Policy Type: PolicyType.UriMatchDefaults (value 16) that enables organization administrators to:

  • Set a default URI match type (Domain, Host, StartsWith, Exact, RegularExpression, Never) for all new vault items
  • Enforce consistent auto-fill matching behavior across the organization

Implementation Details:

  • Add new enum value for UriMatchDefaults = 16 and PolicyType.UriMatchDefaults => "URI match defaults",
  • Backwards Compatibility: Uses existing policy infrastructure - no API changes required
  • Database: Leverages existing Policy table JSON storage - no schema changes needed

Use Cases:

  • Organizations can standardize how auto-fill matching works for security consistency

Files Changed:

  • PolicyType.cs - Added new enum value and display name

This feature helps organizations improve security by standardizing URI matching behavior while maintaining the ability for users to override the configured default setting for each cipher.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@bensbits91 bensbits91 self-assigned this Sep 5, 2025
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Logo
Checkmarx One – Scan Summary & Details1b674758-7b40-42ae-a025-725f453731cd

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.96%. Comparing base (18aed0b) to head (68e4a42).

Files with missing lines Patch % Lines
src/Core/AdminConsole/Enums/PolicyType.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6294      +/-   ##
==========================================
- Coverage   49.96%   49.96%   -0.01%     
==========================================
  Files        1824     1824              
  Lines       80956    80957       +1     
  Branches     7184     7184              
==========================================
  Hits        40452    40452              
- Misses      38958    38959       +1     
  Partials     1546     1546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant