-
-
Notifications
You must be signed in to change notification settings - Fork 287
Upgrade Scala to 3.7.3 (was 3.7.2) #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wojciech Mazur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @WojciechMazur, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine version upgrade for Scala 3 from 3.7.2 to 3.7.3. The changes primarily involve updating version numbers and associated checksums across the codebase to align with the new Scala release, ensuring the project remains up-to-date with the latest compiler and library versions.
Highlights
- Scala Version Bump: The core change updates the Scala 3 version from 3.7.2 to 3.7.3 across various configuration and build files.
- Build System Updates: Bazel-related files (MODULE.bazel, WORKSPACE files) have been updated to reflect the new Scala version, including compiler source JAR URLs and integrity hashes.
- Testing and Scripting Adjustments: Test scripts and utility scripts that reference Scala versions have been updated to include or use the new 3.7.3 version, ensuring compatibility and correct behavior with the upgraded compiler.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly upgrades Scala from version 3.7.2 to 3.7.3. The changes are consistent across all modified files, including build configurations, tests, and documentation. While the update is well-executed, I've noticed that the list of supported Scala versions is maintained in multiple files. I've added a suggestion to consolidate this into a single source of truth to improve maintainability and simplify future updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexeagle @Wyverald or whoever has access: Can you please disable gemini-code-assist for the |
I'm not an admin in bazel-contrib. Probably @alexeagle or @keith can help. |
Description
Upgrades Scala 3.7 to 3.7.3 as part of release process procedure scala/scala3#23887
Motivation
scala/scala3#23887