Skip to content

Allow version-aware naming for artifact repositories #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Allow version-aware naming for artifact repositories #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions third_party/repositories/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ load(
load(
"@io_bazel_rules_scala//scala:scala_cross_version.bzl",
"default_maven_server_urls",
"extract_major_version",
"version_suffix",
)
load(
"@io_bazel_rules_scala//scala:scala_maven_import_external.bzl",
_scala_maven_import_external = "scala_maven_import_external",
)
load("@io_bazel_rules_scala_config//:config.bzl", "SCALA_MAJOR_VERSION", "SCALA_VERSION")
load("@io_bazel_rules_scala_config//:config.bzl", "SCALA_VERSION")

artifacts_by_major_scala_version = {
"2.11": _artifacts_2_11,
Expand All @@ -57,31 +59,42 @@ scala_version_by_major_scala_version = {
}

def repositories(
scala_version = None,
for_artifact_ids = [],
maven_servers = default_maven_server_urls(),
overriden_artifacts = {},
fetch_sources = True,
validate_scala_version = False):
major_scala_version = SCALA_MAJOR_VERSION
"""
Downloads given artifacts.

If `scala_version` is provided, artifacts will be downloaded for that Scala version.
Also version-aware naming of repositories will be used (appending a suffix).
Otherwise, the default Scala version is used and repository names have no suffix.
"""

suffix = version_suffix(scala_version) if scala_version else ""
scala_version = scala_version or SCALA_VERSION
major_scala_version = extract_major_version(scala_version)

if validate_scala_version:
repository_scala_version = scala_version_by_major_scala_version[SCALA_MAJOR_VERSION]
default_version_matches = SCALA_VERSION == repository_scala_version
repository_scala_version = scala_version_by_major_scala_version[major_scala_version]
default_version_matches = scala_version == repository_scala_version

if not default_version_matches and len(overriden_artifacts) == 0:
version_message = "Scala config (%s) version does not match repository version (%s)"
fail(version_message % (SCALA_VERSION, repository_scala_version))
fail(version_message % (scala_version, repository_scala_version))

default_artifacts = artifacts_by_major_scala_version[major_scala_version]
artifacts = dict(default_artifacts.items() + overriden_artifacts.items())
for id in for_artifact_ids:
_scala_maven_import_external(
name = id,
name = id + suffix,
artifact = artifacts[id]["artifact"],
artifact_sha256 = artifacts[id]["sha256"],
licenses = ["notice"],
server_urls = maven_servers,
deps = artifacts[id].get("deps", []),
deps = [dep + suffix for dep in artifacts[id].get("deps", [])],
runtime_deps = artifacts[id].get("runtime_deps", []),
testonly_ = artifacts[id].get("testonly", False),
fetch_sources = fetch_sources,
Expand Down