Upgrade Scala 2.13.12 and fix compilation issues in reporters #1517
Conversation
scoquelin
force-pushed
the
upgrade-scala-2.13.12
branch
2 times, most recently
from
539f039 to
a07c0e8
Compare
...va/io/bazel/rulesscala/scalac/deps_tracking_reporter/after_2_13_12/DepsTrackingReporter.java
Outdated
Show resolved
Hide resolved
|
@scoquelin please rebase/resolve conflicts |
scoquelin
force-pushed
the
upgrade-scala-2.13.12
branch
6 times, most recently
from
b3ba33f to
e59fb0e
Compare
| } | ||
|
|
||
| @Override | ||
| public void doReport(Position pos, String msg, Severity severity, scala.collection.immutable.List<CodeAction> actions) { |
There was a problem hiding this comment.
TLDR; After doing some troubleshooting, found out that the workaround was to override doReport instead of info0 as mentioned here.
Long version : figured out that the usedJars were not populated properly in DepsTrackingReporter since the overridden info0 method (responsible for building the list of used jars) didn't seem to be called, and that led to issues computing the actual list of unused dependencies reason why the build was failing, wrongly reporting unused dependencies whereas they were actually used.
Turns out that the compiler patch that calls inform which in turns calls echo now invokes doReport... so to get input about the used jars from the compiler source doReport now needs to be overridden starting from Scala 2.13.12...
Will rebase again when #1518 will be merged but unused dependencies issue is now fixed 🥳 |
scoquelin
force-pushed
the
upgrade-scala-2.13.12
branch
from
e59fb0e to
628c936
Compare
Description
Bringing Scala
2.13.12support by fixing reporters while maintaining backward compatibility with other Scala versionsRequires #1515 and #1518
Motivation
Closes #1514