-
Notifications
You must be signed in to change notification settings - Fork 169
Dockerize #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Dockerize #561
Conversation
AFAICT, your last commit for custom domains won't work for users not using Docker. Could you please provide an alternative or an equivalent approach not to break their config? |
It uses an enviro variable, non-docker users should be able to set it too without any major changes to their config. HOST=nintendowifi.net python master_server.py I'd use a more unique name in case of conflicts, i.e. |
This approach is not trivial for Windows users as they most likely use GUI tools rather than CLI. Especially, for Apache. Moreover Apache provides a |
Please be aware that this will likely only work on linux anyways, as it requires the |
This PR probably isn't getting merged anytime soon. Fork possible? |
This is already a fork, that's how most PRs work. https://github.com/florensie/dwc_network_server_emulator |
I know, I just meant a full fork for including this and some of the other PRs/issues that aren't being fixed, so that there's a chance someone could actively work on the project again |
If someone wants to work on the project, they will. I don't see how that has anything to do with this PR. |
@florensie could you please explain if this part is needed if I only intend to have this server only visible in LAN/VPN?
|
IIRC, DWC_HOST needs to be set for this to work at all. Either you use the default and set up a local DNS/hosts file to re-route traffic to that domain. Or you need to set your own domain name, and patch your ROM (or use a cheat in Dolphin?) to use that domain instead of Nintendo's. |
No description provided.