Update "bad" bucket names in PHP examples displayed in the PHP Dev. guide #7563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C++
tkhill-AWS
force-pushed
the
php-bucket-names
branch
from
152eac7 to
46e6b6f
Compare
github-actions
bot
removed
C++
beqqrry-aws
approved these changes
Sep 3, 2025
beqqrry-aws
added
On Call Review needed
tejasgn1
added
On Call Review complete
shepazon
pushed a commit
to shepazon/aws-doc-sdk-examples
that referenced
this pull request
Sep 11, 2025
…uide (awsdocs#7563) Change in PHP for updating s3 bucket names looks good. Fix for https://taskei.amazon.dev/tasks/PHP-3162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the last few s3 bucket names in PHP examples to the TCX required change. It replaces bucket names like "my-bucket" to TCX approved names like "amzn-s3-demo-bucket".
The scan report of the bad bucket names, flagged pages in the PHP Developer guide, and these final changes appear to affect code examples that only appear in the guide, not in the Code Library itself.
For safe measure, as I worked through updating the changes, I found a few other "bad" bucket names, that I fixed anyway, even though I did not see them as flagged.
Ticket this PR addresses: https://taskei.amazon.dev/tasks/PHP-3162
I did a CDD build of the Code Library, but since these updates won't appear there, it's not very useful.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.