Skip to content

build(CI): install cross from the latest commit #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

build(CI): install cross from the latest commit #2804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,7 @@ jobs:

- name: Install cross
if: ${{ matrix.target != 'native' }}
uses: camshaft/install@v1
with:
crate: cross
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we can use the install tool with version: latest. Maybe that will pull in the newest cross?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, since the default value for version is latest. Here is the doc for install tool: https://github.com/camshaft/install?tab=readme-ov-file#inputs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why isn't this tool pulling in the latest cross version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install tool is indeed pulling in the latest cross version which is 0.2.5 https://crates.io/crates/cross/versions. The version 0.2.5 is indeed the latest version according to crates.io. However, that version is released over 2 years ago and there has been lots of commits added to the repo: https://github.com/cross-rs/cross.

Their own README.md also recommended to install cross from git instead of crates.io: https://github.com/cross-rs/cross?tab=readme-ov-file#installation.

So, the install tool is installing v0.2.5 which is over two years ago. This PR is installing cross from the latest commit, which is two weeks ago as of today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, maybe we want to put this back once cross does another release, it does look like they are preparing for 0.3 to be released ~sometime. But if they're that slow on releases we can't wait for that, nor should we wait for aws-lc to fix the issue, as their releases are also slow. Regardless, we probably could revert this change in the future.

run: cargo install cross --git https://github.com/cross-rs/cross

- uses: camshaft/rust-cache@v1
with:
Expand Down
Loading