Skip to content

Conversation

falnyr
Copy link

@falnyr falnyr commented Aug 17, 2025

Description

To support multiple agents being tested at the same time and also to allow users to override the port 8080 which other applications may be using at the time.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Testing

  • Unit tests pass locally
  • Integration tests pass (if applicable)
  • Test coverage remains above 80%
  • Manual testing completed

Checklist

  • My code follows the project's style guidelines (ruff/pre-commit)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Security Checklist

  • No hardcoded secrets or credentials
  • No new security warnings from bandit
  • Dependencies are from trusted sources
  • No sensitive data logged

Breaking Changes

N/A

To support multiple agents being tested at the same time and also to allow users to override the port 8080 which other applications may be using at the time.
@siwachabhi siwachabhi self-requested a review September 5, 2025 00:11
@@ -53,9 +53,11 @@ agentcore launch # Uses CodeBuild - no Docker needed

### 💻 Local Development
```bash
agentcore launch --local # Build and run locally
agentcore launch --local # Build and run locally (port 8080)
AGENTCORE_RUNTIME_LOCAL_PORT=9000 agentcore launch --local # Custom port
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets only introduce this in troubleshooting step in quick start around conflict ports, risk we are seeing with different ports is that runtime supports only a fixed port, so didn't want to cause confusion for devs in default cases

@siwachabhi siwachabhi added enhancement New feature or request runtime Related to agentcore runtime labels Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request runtime Related to agentcore runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants