feat: add agentcore destroy command #100

huanshenyi · 2025-08-05T03:20:11Z

Description

Brief description of changes

Type of Change

New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Performance improvement
Code refactoring

Testing

Unit tests pass locally
Integration tests pass (if applicable)
Test coverage remains above 80%
Manual testing completed

Checklist

My code follows the project's style guidelines (ruff/pre-commit)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published

Security Checklist

No hardcoded secrets or credentials
No new security warnings from bandit
Dependencies are from trusted sources

No sensitive data logged

Breaking Changes

N/A - This is an additive feature that doesn't modify existing functionality.

Additional Notes

New Command Usage

agentcore destroy                    # Destroy default agent (with confirmation)
agentcore destroy --agent my-agent  # Destroy specific agent
agentcore destroy --dry-run         # Preview what would be destroyed
agentcore destroy --force           # Skip confirmation prompts

Resources Cleaned Up

- Bedrock AgentCore endpoints
- Bedrock AgentCore agent runtimes
- ECR images (latest tag only for safety)
- CodeBuild projects
- IAM execution roles (only if not used by other agents)
- Agent deployment configuration

Safety Features

- Confirmation prompts by default
- Dry-run mode to preview changes
- Shared resource protection (won't delete IAM roles used by multiple agents)
- Comprehensive error handling and logging
- Graceful handling of already-deleted resources

Test Coverage

- 25+ comprehensive unit tests covering all scenarios
- CLI integration tests
- Error handling and edge case testing
- Mock-based testing for AWS service interactions

Signed-off-by: Syoitu Den <[email protected]>

Vivekbhadauria1 · 2025-09-04T04:59:31Z

src/bedrock_agentcore_starter_toolkit/operations/runtime/destroy.py

+            endpoint_response = client.get_agent_runtime_endpoint(agent_id)
+            endpoint_arn = endpoint_response.get("agentRuntimeEndpointArn")
+            if endpoint_arn:
+                # Note: There's no direct delete endpoint method in the current client


we should use https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/bedrock-agentcore-control/client/delete_agent_runtime_endpoint.html.

Vivekbhadauria1

Thanks for merging latest changes. Needs a couple of changes -

Code build IAM role starting with prefix AmazonBedrockAgentCoreSDKCodeBuild* needs to be deleted if developers uses code-build.
The delete endpoint needs to special case "DEFAULT" endpoint that can not be explicitly created/deleted.

…oy codebuild role

Vivekbhadauria1 · 2025-09-04T15:45:24Z

src/bedrock_agentcore_starter_toolkit/operations/runtime/destroy.py

+    result: DestroyResult,
+    dry_run: bool,
+) -> None:
+    """Remove all CodeBuild IAM roles with prefix AmazonBedrockAgentCoreSDKCodeBuild*"""


only delete the code build role associated with agent. You can read the config file similar to agent's execution role. The code build role is at "codebuild.execution_role" in the agent's config.

Vivekbhadauria1

Thanks! left a few comment on config file cleanup that is being left in an invalid state post destroy.

Vivekbhadauria1 · 2025-09-04T23:41:00Z

src/bedrock_agentcore_starter_toolkit/operations/runtime/destroy.py

+        role_name = role_arn.split("/")[-1]
+
+        if dry_run:
+            result.resources_removed.append(f"DRY RUN: would remove CodeBuild IAM role: {role_name}")


Inconsistent with other dry logs. should be "CodeBuild IAM role (DRY RUN) "

Vivekbhadauria1 · 2025-09-04T23:49:15Z

src/bedrock_agentcore_starter_toolkit/operations/runtime/destroy.py

+    try:
+        # Clear the bedrock_agentcore deployment info but keep the agent config
+        if agent_name in project_config.agents:
+            agent_config = project_config.agents[agent_name]


The agent specific entry should be removed and not just the bedrock_agentcore. This causes the subsequent status/configure/launch calls to fail.

Vivekbhadauria1 · 2025-09-04T23:57:04Z

src/bedrock_agentcore_starter_toolkit/operations/runtime/destroy.py

+    """Remove agent configuration from the config file."""
+    try:
+        # Clear the bedrock_agentcore deployment info but keep the agent config
+        if agent_name in project_config.agents:


Default agent name needs to be cleaned up in the config. If there is only one agent and its being destroyed we can remove the config file. Else, we can set the default to next valid agent in the file.

Vivekbhadauria1

A couple of doc related comments.

Vivekbhadauria1 · 2025-09-05T09:37:08Z

README.md

+```bash
+# Deploy with the Starter Toolkit
+agentcore configure --entrypoint my_agent.py
+agentcore launch  # Ready to run on Bedrock AgentCore
+agentcore invoke '{"prompt": "tell me a fact"}'
+agentcore destroy
+```
+
+**What you get with the Starter Toolkit:**
+
+- ✅ **Keep your agent logic** - Works with any SDK-built agent
+- ✅ **Zero infrastructure management** - No servers, containers, or scaling concerns
+- ✅ **One-command deployment** - From local development to enterprise platform
+- ✅ **Production-ready hosting** - Reliable, scalable, compliant Bedrock AgentCore deployment
+
+## 🛠️ Deployment & Management Tools
+
+**Simple Configuration**
+
+```bash
+# Configure your agent for deployment
+agentcore configure --entrypoint my_agent.py --name my-production-agent
+
+# Check deployment status
+agentcore status
+
+# Invoke your deployed agent
+agentcore invoke '{"prompt": "Hello from Bedrock AgentCore!"}'
+```
+


This has been moved to AgentCore Runtime Quick start and need not be present at top-level documentation. Please update bedrock-agentcore-starter-toolkit/user-guide/runtime/quickstart instead.

Vivekbhadauria1 · 2025-09-05T09:38:03Z

README.md

+## 📚 About Amazon Bedrock AgentCore
+
+Amazon Bedrock AgentCore enables you to deploy and operate highly effective agents securely, at scale using any framework and model. With AgentCore, developers can accelerate AI agents into production with enterprise-grade scale, reliability, and security. The platform provides:
+
+- **Composable Services**: Mix and match services to fit your needs
+- **Framework Flexibility**: Works with Strands, LangGraph, CrewAI, Strands, and more
+- **Any Model Support**: Not locked into specific models
+- **Enterprise Security**: Built-in identity, isolation, and access controls


Please sync content from https://github.com/aws/bedrock-agentcore-starter-toolkit. Ideally there should be no new change to this file for destroy.

@Vivekbhadauria1
Thank you so much for your patience and guidance! I'm really grateful I could help you address the documentation feedback. Your
implementation of the destroy functionality is excellent work.

We're still working through the review process, but I appreciate you taking the time to collaborate on getting everything just right. It's
been a pleasure working with you on this contribution! 🙏

Vivekbhadauria1

Hey, The tests are failing - https://github.com/aws/bedrock-agentcore-starter-toolkit/actions/runs/17495999286/job/49711013016?pr=100. Please take a look.

…ration

Vivekbhadauria1 · 2025-09-06T13:50:02Z

The Test coverage gate is failing. Please take a look.
ERROR: Coverage failure: total of 89.31 is less than fail-under=90.00

… warnings

huanshenyi added 4 commits August 5, 2025 12:11

feat: add agentcore destroy command

22680fc

fix: improve ECR image deletion logic

8c0d866

fix: correct ECR API response format from imageDetails to imageIds

0a23494

fix: ECR detection issue in cleanup process

f54c0a7

huanshenyi force-pushed the feature/add-destroy-command branch from deb99f2 to f54c0a7 Compare August 5, 2025 07:35

Merge branch 'main' into feature/add-destroy-command

5cdea2d

Signed-off-by: Syoitu Den <[email protected]>

huanshenyi had a problem deploying to manual-approval August 8, 2025 14:19 — with GitHub Actions Failure

Vivekbhadauria1 reviewed Sep 4, 2025

View reviewed changes

huanshenyi added 2 commits September 4, 2025 20:29

feat: implement agent runtime endpoint deletion

2795204

Merge branch 'main' into feature/add-destroy-commands

9a34b4d

huanshenyi requested a review from Vivekbhadauria1 September 4, 2025 11:39

Vivekbhadauria1 requested changes Sep 4, 2025

View reviewed changes

fix: skip deletion of DEFAULT endpoint in destroy operation and destr…

f02d5e6

…oy codebuild role

huanshenyi requested a review from Vivekbhadauria1 September 4, 2025 14:57

Vivekbhadauria1 requested changes Sep 4, 2025

View reviewed changes

huanshenyi requested a deployment to manual-approval September 4, 2025 16:16 — with GitHub Actions Waiting

fix: only delete the CodeBuild role associated with agent

2369884

huanshenyi requested a review from Vivekbhadauria1 September 4, 2025 22:55

Vivekbhadauria1 requested changes Sep 5, 2025

View reviewed changes

fix: improve agent configuration cleanup and logging consistency

40c75ae

huanshenyi requested a review from Vivekbhadauria1 September 5, 2025 08:49

Vivekbhadauria1 requested changes Sep 5, 2025

View reviewed changes

docs: remove duplicate content from README and sync with main repository

83273bc

huanshenyi requested a review from Vivekbhadauria1 September 5, 2025 14:28

Vivekbhadauria1 approved these changes Sep 5, 2025

View reviewed changes

huanshenyi had a problem deploying to manual-approval September 5, 2025 17:30 — with GitHub Actions Failure

Vivekbhadauria1 requested changes Sep 5, 2025

View reviewed changes

fix: correct test expectation for config file deletion in destroy ope…

d2109fb

…ration

huanshenyi requested a review from Vivekbhadauria1 September 6, 2025 01:01

huanshenyi requested a deployment to manual-approval September 6, 2025 02:11 — with GitHub Actions Waiting

fix: increase coverage for destroy module

12fb58d

huanshenyi requested a deployment to manual-approval September 6, 2025 13:47 — with GitHub Actions Waiting

fix: improve destroy module coverage from 89% to 98%

1092710

huanshenyi requested a deployment to manual-approval September 6, 2025 18:14 — with GitHub Actions Waiting

huanshenyi added 2 commits September 7, 2025 09:07

fix: improve test coverage to reach 90% threshold and fix deprecation…

ebfa40d

… warnings

Merge branch 'main' into feature/add-destroy-commands

fe64676

huanshenyi had a problem deploying to manual-approval September 7, 2025 19:44 — with GitHub Actions Failure

fix: add test cases to reach 90% coverage threshold for destroy module

61e6052

huanshenyi requested a deployment to manual-approval September 8, 2025 05:15 — with GitHub Actions Waiting

Vivekbhadauria1 approved these changes Sep 8, 2025

View reviewed changes

Vivekbhadauria1 merged commit 0611649 into aws:main Sep 8, 2025
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add agentcore destroy command #100

feat: add agentcore destroy command #100

huanshenyi commented Aug 5, 2025

Uh oh!

Vivekbhadauria1 Sep 4, 2025

Uh oh!

Vivekbhadauria1 left a comment •

edited

Loading

Uh oh!

Vivekbhadauria1 Sep 4, 2025

Uh oh!

Vivekbhadauria1 left a comment

Uh oh!

Vivekbhadauria1 Sep 4, 2025

Uh oh!

Vivekbhadauria1 Sep 4, 2025

Uh oh!

Vivekbhadauria1 Sep 4, 2025

Uh oh!

Vivekbhadauria1 left a comment

Uh oh!

Vivekbhadauria1 Sep 5, 2025

Uh oh!

Vivekbhadauria1 Sep 5, 2025

Uh oh!

huanshenyi Sep 5, 2025

Uh oh!

Vivekbhadauria1 left a comment

Uh oh!

Vivekbhadauria1 commented Sep 6, 2025

Uh oh!

Uh oh!

Uh oh!

feat: add agentcore destroy command #100

feat: add agentcore destroy command #100

Conversation

huanshenyi commented Aug 5, 2025

Description

Type of Change

Testing

Checklist

Security Checklist

Breaking Changes

Additional Notes

New Command Usage

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vivekbhadauria1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vivekbhadauria1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vivekbhadauria1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vivekbhadauria1 left a comment

Choose a reason for hiding this comment

Uh oh!

Vivekbhadauria1 commented Sep 6, 2025

Uh oh!

Uh oh!

Uh oh!

Vivekbhadauria1 left a comment •

edited

Loading