feat: add validation for browser live view URL expiry timeout #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add client-side validation to prevent service-side 4xx errors when generating browser live view URLs with invalid expiry timeouts.
Changes
generate_live_view_url()
to ensureexpiry_timeout_seconds
cannot exceed 300 secondsValueError
with descriptive message when timeout exceeds the limitWhy this change?
Prevents users from encountering confusing 4xx errors from the service by catching invalid timeout values early on the client side.
Files Changed
src/bedrock_agentcore/tools/browser_client.py
- Added validation logictests/bedrock_agentcore/tools/test_browser_client.py
- Added test casesTesting