add automated release workflows (PyPI disabled for testing) #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoken1
reviewed
Aug 1, 2025
guoken1
reviewed
Aug 1, 2025
guoken1
reviewed
Aug 1, 2025
.github/workflows/pr-automerge.yml
Outdated
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Check PR approval status |
There was a problem hiding this comment.
this step is checking whether the pr is approved, so we probably don't need to perform this check immediately when the pr is opened
There was a problem hiding this comment.
Since we're only checking PR status, no checkout needed
guoken1
reviewed
Aug 1, 2025
.github/workflows/pr-automerge.yml
Outdated
| ref: context.payload.pull_request.head.sha | ||
| }); | ||
|
|
||
| const requiredChecks = ['Lint', 'Test Python 3.10']; |
There was a problem hiding this comment.
I think we should include all our checks here
There was a problem hiding this comment.
now includes all Python version tests and build checks
guoken1
reviewed
Aug 1, 2025
guoken1
reviewed
Aug 1, 2025
guoken1
reviewed
Aug 1, 2025
|
|
||
|
|
||
| test-and-build: | ||
| name: Test and Build |
There was a problem hiding this comment.
I don't think there are tests in this job
guoken1
reviewed
Aug 1, 2025
guoken1
reviewed
Aug 1, 2025
guoken1
reviewed
Aug 1, 2025
guoken1
reviewed
Aug 6, 2025
| }); | ||
|
|
||
| // Include ALL required checks | ||
| const requiredChecks = [ |
There was a problem hiding this comment.
consider adding integration tests too
guoken1
reviewed
Aug 6, 2025
| echo "⚠️ MANUAL APPROVAL REQUIRED FOR PRODUCTION" | ||
| echo "" | ||
| echo "Before approving:" | ||
| echo "1. Test package: pip install -i https://test.pypi.org/simple/ bedrock-agentcore" |
guoken1
reviewed
Aug 6, 2025
| content = Path("pyproject.toml").read_text() | ||
| # More robust regex that matches the project version specifically | ||
| # Look for version under [project] or [tool.poetry] sections | ||
| pattern = r'(?:^\[project\]|\[tool\.poetry\])[\s\S]*?^version\s*=\s*"([^"]+)"' |
There was a problem hiding this comment.
we are not using poetry so we can remove it
guoken1
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
add automated release workflows (PyPI disabled for testing)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.