Skip to content

Conversation

sundargthb
Copy link
Contributor

  • Fix OAuth2 parameter name in identity module
  • Improve JSON serialization consistency
  • Fix memory client region detection
  • Fix JSON response double wrapping issue

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Fix OAuth2 parameter name in identity module
- Improve JSON serialization consistency
- Fix memory client region detection
- Fix JSON response double wrapping issue
# When region_name is provided, environment variable should still take precedence
client1 = MemoryClient(region_name="us-west-2")
assert client1.region_name == "us-east-1" # Environment wins over explicit param
assert client1.region_name == "us-west-2" # Environment wins over explicit param
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment should be updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch.

@sundargthb sundargthb merged commit 5359f91 into main Jul 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants