chore(core/protocols): add fallback for schema short name #7314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Sep 4, 2025
| const hasBody = Object.values(members).find((m) => { | ||
| const { httpQuery, httpQueryParams, httpHeader, httpLabel, httpPrefixHeaders } = m.getMergedTraits(); | ||
| return !httpQuery && !httpQueryParams && !httpHeader && !httpLabel && httpPrefixHeaders === void 0; | ||
| const noPrefixHeaders = httpPrefixHeaders === void 0; |
There was a problem hiding this comment.
added this variable because the previous expression was potentially confusing as to the order of operations of && and ===.
smilkuri
approved these changes
Sep 5, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
smithy-lang/smithy-typescript#1600 (epic)
smithy-lang/smithy-typescript#1681 - schema refactor includes adding a namespace string to all unwrapped schema objects, such that the
namefield contains only the short name.Description
Makes the SDK compatible with both pre and post merge of the above smithy-ts PR.
Testing
make test-protocolsboth with current code and changes from 1681Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?