-
Notifications
You must be signed in to change notification settings - Fork 939
Feature/master/utils lite lambda trace #6404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9badcf1
to
85642fe
Compare
zoewangg
reviewed
Sep 11, 2025
joviegas
reviewed
Sep 11, 2025
.../architecture-tests/src/test/java/software/amazon/awssdk/archtests/UtilsLitePackageTest.java
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/awscore/interceptor/TraceIdExecutionInterceptor.java
Show resolved
Hide resolved
utils-lite/src/main/java/software/amazon/awssdk/utilslite/SdkInternalThreadLocal.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Sep 11, 2025
...re/src/main/java/software/amazon/awssdk/awscore/interceptor/TraceIdExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Sep 11, 2025
...re/src/main/java/software/amazon/awssdk/awscore/interceptor/TraceIdExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Sep 12, 2025
utils-lite/src/main/java/software/amazon/awssdk/utilslite/SdkInternalThreadLocal.java
Outdated
Show resolved
Hide resolved
utils-lite/src/main/java/software/amazon/awssdk/utilslite/SdkInternalThreadLocal.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Sep 12, 2025
utils-lite/src/main/java/software/amazon/awssdk/utilslite/SdkInternalThreadLocal.java
Show resolved
Hide resolved
18ce92a
to
8462a02
Compare
zoewangg
reviewed
Sep 12, 2025
...re/src/main/java/software/amazon/awssdk/awscore/interceptor/TraceIdExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/awscore/interceptor/TraceIdExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
90927c1
to
886f7d1
Compare
zoewangg
approved these changes
Sep 16, 2025
joviegas
reviewed
Sep 16, 2025
...odegen-generated-classes-test/src/test/java/software/amazon/awssdk/services/TraceIdTest.java
Show resolved
Hide resolved
464b902
to
354048d
Compare
joviegas
approved these changes
Sep 18, 2025
Add utils-lite package
Add support for concurrent trace id propagation
4034534
to
73427bb
Compare
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api-surface-area-approved-by-team
Indicate API surface area introduced by this PR has been approved by team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
SdkInternalThreadLocal
, a wrapper around threadLocal.Background
Previously, we implemented trace ID propagation using SLF4J's MDC in PR #6363, but this was
reverted because the MDC interface exists but the implementation is not provided by the SDK, Lambda runtime, or X-Ray SDK.
Solution
Added a small
utils-lite
utility class that provides thread local key value storage usingThreadLocal<Map<String, String>>
. For this case, it allows the Lambda Runtime Interface Client, AWS SDK, and X-Ray SDK to share trace context via this one package, but can extended to other use cases.Example: