Skip to content

Conversation

BorisLeMeec
Copy link

Issue #, if available:
#370

Description of changes:
added new event struct for support of customEmailSender messages.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.66%. Comparing base (80c32f1) to head (3b3640c).
Report is 80 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   71.66%   71.66%           
=======================================
  Files          19       19           
  Lines        1041     1041           
=======================================
  Hits          746      746           
  Misses        228      228           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmoffatt
Copy link
Collaborator

bmoffatt commented Jan 7, 2022

LGTM, do you have an AWS docs link for this feature that I can reference?

@rubengp99
Copy link

Can we cover custom SMS sender as well?

@BorisLeMeec
Copy link
Author

Sure, I will add the same for SMS, I have few time available atm, but asap.
@bmoffatt I'll add the link from documentation

@hgpestana
Copy link

Hey, do you have any updates on this? @BorisLeMeec, do you need any help?

type CognitoEventUserPoolsCustomEmailSender struct {
CognitoEventUserPoolsHeader
Request CognitoEventUserPoolsCustomEmailSenderRequest `json:"request"`
Response CognitoEventUserPoolsCustomEmailSenderResponse `json:"response"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs don't mention a returned response, I think the sender integration isn't quite the same as the Custom Message integration

Email Sender: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-email-sender.html

The custom code of your function must then process and deliver the message.

Compare with Custom Message Trigger: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-message.html#cognito-user-pools-lambda-trigger-syntax-custom-message

In the response, specify the custom text to use in messages to your users.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the response fields should be an empty object:
But the returned response is mentioned here: https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pools-working-with-lambda-triggers.html#working-with-lambda-trigger-sources

@bmoffatt bmoffatt added the type/events issue or feature request related to the events package label Dec 21, 2022
@kmacmcfarlane
Copy link

Is this change still happening? Running into the need for the Email/SMS event models in a project I'm working on

@moraitisk
Copy link

moraitisk commented Jun 26, 2023

Hey, @BorisLeMeec, @bmoffatt is there an update regarding the support for the custom email sender event? Are there any blockers for merging this?

@MauritsBarendregt
Copy link

Bump, any updates on this one? Anyone uses a workaround?

@yomipq
Copy link

yomipq commented May 12, 2025

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/events issue or feature request related to the events package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants