Sync Service/Deployment changes #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts. EndpointSlice events are triggered by Service or Deployment changes. Refactor ServiceExport to handle the deletion scenario when the Service corresponding to ServiceExport is deleted. Also, updating the e2e test to accommodate the scale-up scenario. Improvements in unit tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 76.30% 73.52% -2.78%
==========================================
Files 14 14
Lines 1224 1292 +68
==========================================
+ Hits 934 950 +16
- Misses 226 274 +48
- Partials 64 68 +4
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
astaticvoid
previously approved these changes
Nov 19, 2021
| if cmService != nil { | ||
| if err := r.CloudMap.DeleteEndpoints(ctx, cmService.Namespace, cmService.Name, cmService.Endpoints); err != nil { | ||
| r.Log.Error(err, "error while deleting endpoints from Cloud Map", | ||
| "namespace", cmService.Namespace, "name", cmService.Name) | ||
| return ctrl.Result{}, err |
There was a problem hiding this comment.
I guess in the future we'll return something other than empty struct.
There was a problem hiding this comment.
Right now our strategy seems to be just log error, and move on. We have to probably figure out fault-tolerance strategy before GA.
astaticvoid
approved these changes
Nov 19, 2021
bendu
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #20
Description of changes: Adding the listener to the Service Export Controller to track EndpointSlice events. EndpointSlice events are triggered by Service or Deployment changes. Refactor ServiceExport to handle the deletion scenario when the Service corresponding to ServiceExport is deleted. Also, updating the e2e test to accommodate the scale-up scenario. Improvements in unit tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.