Skip to content

Conversation

astaticvoid
Copy link
Contributor

Issue #, if available:
#69

Description of changes:
Run integration test for push and pull requests. Uses repo environment secrets to setup AWS credentials.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@astaticvoid astaticvoid force-pushed the dhemmerl-integration-workflow branch from 1b012a5 to 398dcb1 Compare November 10, 2021 16:57
@astaticvoid
Copy link
Contributor Author

It appears the integration test is not useful for pull requests since the environment secrets will not be available if PR is from forked repo, even if the deployment is approved by us.
We can use it on push, which gives us confidence before releasing at least. Also provision to run locally gives us some mostly automated assurances before creating the PR.

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we should do that.
It was my original intent, but I hit some policy snags setting up our testing account. Let me take another crack at it for the next revision.

@runakash
Copy link
Member

It appears the integration test is not useful for pull requests since the environment secrets will not be available if PR is from forked repo, even if the deployment is approved by us.

How about we run this periodically just for the main branch?

@bendu
Copy link
Contributor

bendu commented Nov 10, 2021

It appears the integration test is not useful for pull requests since the environment secrets will not be available if PR is from forked repo, even if the deployment is approved by us.

How about we run this periodically just for the main branch?

I'm good with either periodic or just on push.

@astaticvoid astaticvoid force-pushed the dhemmerl-integration-workflow branch from 398dcb1 to ece4cc9 Compare November 11, 2021 18:04
@astaticvoid astaticvoid merged commit c0a67bc into aws:main Nov 11, 2021
@astaticvoid astaticvoid deleted the dhemmerl-integration-workflow branch November 11, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants