-
Notifications
You must be signed in to change notification settings - Fork 29
Add integration test workflow #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test workflow #71
Conversation
1b012a5
to
398dcb1
Compare
It appears the integration test is not useful for pull requests since the environment secrets will not be available if PR is from forked repo, even if the deployment is approved by us. |
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v1 | ||
with: | ||
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the github actions OIDC provider instead, so we don't have to remember to rotate the creds.
See https://github.com/aws-actions/configure-aws-credentials#assuming-a-role and https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we should do that.
It was my original intent, but I hit some policy snags setting up our testing account. Let me take another crack at it for the next revision.
How about we run this periodically just for the |
I'm good with either periodic or just on push. |
398dcb1
to
ece4cc9
Compare
Issue #, if available:
#69
Description of changes:
Run integration test for push and pull requests. Uses repo environment secrets to setup AWS credentials.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.