Add the support for creating service with DNS namespace type #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 37.94% 42.32% +4.38%
==========================================
Files 9 9
Lines 954 997 +43
==========================================
+ Hits 362 422 +60
+ Misses 579 560 -19
- Partials 13 15 +2
Continue to review full report at Codecov.
|
vanekjar
suggested changes
Oct 21, 2021
There was a problem hiding this comment.
Thanks, it looks good! Can you please also rebase on top of the current main? @astaticvoid refactored bunch of interfaces and there may be minor adjustments needed.
|
Linking #18 |
astaticvoid
reviewed
Oct 21, 2021
runakash
force-pushed
the
dns-namespace
branch
from
26452b0 to
054b926
Compare
runakash
changed the title
…namespaceCache to support namespace struct.
runakash
force-pushed
the
dns-namespace
branch
2 times, most recently
from
87910f7 to
a99707c
Compare
runakash
force-pushed
the
dns-namespace
branch
from
a99707c to
849f55a
Compare
|
Looks good! I'll let @astaticvoid to check that as well before merging. |
astaticvoid
reviewed
Oct 23, 2021
runakash
force-pushed
the
dns-namespace
branch
from
849f55a to
f6480e4
Compare
…pace types into a enum. Separate constant for dns record ttl config. Add tests for the changes to api.go and caching logic.
runakash
force-pushed
the
dns-namespace
branch
from
f6480e4 to
13c4a6a
Compare
…he logging for unsupported namespace types. Adding more tests.
astaticvoid
approved these changes
Oct 25, 2021
|
Looks great, thanks for the discussions. |
vanekjar
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Handle DNS namespaces along-with the HttpNamespace. Create the Service for the DNS namespace type the type SRV. Update the namespaceCache to support namespace struct.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.