Skip to content

Conversation

runakash
Copy link
Member

Issue #, if available: Fixes #225

Description of changes: Add deletecollection verb. To fix the error encountered with k8s DeleteAllOf operation on endpointslices.discovery.k8s.io.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…teAllOf operation on endpointslices.discovery.k8s.io.
@runakash runakash requested a review from astaticvoid November 15, 2022 03:29
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.47%. Comparing base (4dc8b4d) to head (02e7184).
Report is 161 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files          17       17           
  Lines        1697     1697           
=======================================
  Hits         1213     1213           
  Misses        406      406           
  Partials       78       78           
Files with missing lines Coverage Δ
...kg/controllers/multicluster/cloudmap_controller.go 52.86% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc8b4d...02e7184. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@runakash runakash merged commit c09ae3e into aws:main Nov 15, 2022
@runakash runakash deleted the add-deletecollection-verb branch November 15, 2022 18:59
runakash added a commit to runakash/aws-cloud-map-mcs-controller-for-k8s that referenced this pull request Jun 20, 2025
…teAllOf operation on endpointslices.discovery.k8s.io. (aws#248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller cannot delete endpointslices
3 participants