Rework operation poller #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaticvoid
reviewed
Nov 14, 2022
…. Rework the poller code to keep the OperationPolling simple with Submit - submitting operation provider, Poll - polling operations till complete or timeout, and Await - waiting for the all the submitted operation's result. Moving the rate-limiter to the separate file for the clarity and separation of concerns. Adding the limiter for Register/DeregisterInstance api calls.
runakash
force-pushed
the
rework-operation-poller
branch
from
9abe508 to
5018b44
Compare
astaticvoid
approved these changes
Nov 15, 2022
runakash
added a commit
to runakash/aws-cloud-map-mcs-controller-for-k8s
that referenced
this pull request
Jun 20, 2025
* Replace ListOperations with GetOperation because it has higher limits. Rework the poller code to keep the OperationPolling simple with Submit - submitting operation provider, Poll - polling operations till complete or timeout, and Await - waiting for the all the submitted operation's result. Moving the rate-limiter to the separate file for the clarity and separation of concerns. Adding the limiter for Register/DeregisterInstance api calls. * Add found check in the rate limiters map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Replace ListOperations with GetOperation because it has higher limits. Rework the poller code to keep the OperationPolling simple with Submit - submitting operations, Poll - polling operations till complete or timeout, and Await - waiting for the all the submitted operation's result.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.