Importing Headless Services Support for A/AAAA records #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 72.65% 72.84% +0.19%
==========================================
Files 15 15
Lines 1558 1569 +11
==========================================
+ Hits 1132 1143 +11
Misses 342 342
Partials 84 84
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
astaticvoid
reviewed
Aug 8, 2022
| @@ -174,6 +174,22 @@ func CreateDerivedServiceStruct(svcImport *multiclusterv1alpha1.ServiceImport, i | |||
| svcPorts = append(svcPorts, PortToServicePort(*svcPort)) | |||
| } | |||
|
|
|||
| // if svcImport is Headless type, specify ClusterIP field to "None" | |||
| if svcImport.Spec.Type == multiclusterv1alpha1.Headless { | |||
| return &v1.Service{ | |||
There was a problem hiding this comment.
Duplicate code. Create the struct with the shared values, then conditionally set the differences.
There was a problem hiding this comment.
Also missing unit test coverage.
astaticvoid
approved these changes
Aug 10, 2022
runakash
approved these changes
Aug 10, 2022
runakash
pushed a commit
to runakash/aws-cloud-map-mcs-controller-for-k8s
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #22: Support for headless services
Description of changes:
ServiceImportControllerfor detectingServiceTypeof importing Service and typingServiceImportobject accordingly (either Headless or ClusterSetIP)Note: This change currently only discovers
A/AAAArecords; support forSRVrecords will be added after cluster annotations are added toEndpointSliceswith Source-Cluster label PR (#179). Additionally, the logic currently assumes that all Endpoints have the sameServiceType, and therefore fetches theServiceTypefrom the first endpoint in the Service. This may be changed in the conflict resolution story.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.