Skip to content

Conversation

cameronsenese
Copy link
Contributor

@cameronsenese cameronsenese commented Jan 20, 2022

Issue #126

Description of changes:

Updates to /samples config files and README.md.

Update /samples folder to include:

  • CoreDNS samples to implement CoreDNS multicluster plugin (clusterrole, configmap, and deployment)

Update README.md to:

  • Include minor grammatical updates
  • Mention more clearly network dependencies for successful operation
  • Include instruction to install CoreDNS multicluster plugin
  • Mention more clearly IAM access rights to lifecycle Cloud Map resources

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@astaticvoid astaticvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks for the great coredns patching example, and the improvements to our documentation!

@astaticvoid astaticvoid merged commit 6f90059 into aws:main Feb 14, 2022
runakash pushed a commit to runakash/aws-cloud-map-mcs-controller-for-k8s that referenced this pull request Jun 20, 2025
* Update deployment samples and README.md

* modify updates to deployment samples and README.md

* include example- config files in /samples

* update README.md - standardise kubectl command format and minor grammar/wording changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants