Skip to content

Improve import updates with slice change plans and port deltas #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Improve import updates with slice change plans and port deltas #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1373c3
Improve import updates with slice change plans and port deltas
astaticvoid Dec 2, 2021
3b3f2bc
PR fixes
astaticvoid Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ linters:
- misspell
- whitespace

issues:
exclude-rules:
- path: _test\.go # disable some linters on test files
linters:
- dupl

run:
issues-exit-code: 1
concurrency: 4
Expand Down
5 changes: 3 additions & 2 deletions integration/scenarios/export_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/aws/aws-cloud-map-mcs-controller-for-k8s/pkg/controllers"
"github.com/aws/aws-cloud-map-mcs-controller-for-k8s/pkg/model"
"github.com/aws/aws-sdk-go-v2/aws"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/util/wait"
)

Expand Down Expand Up @@ -46,15 +47,15 @@ func NewExportServiceScenario(cfg *aws.Config, nsName string, svcName string, po
for _, ip := range strings.Split(ips, ",") {
endpointPort := model.Port{
Port: int32(port),
Protocol: model.TCPProtocol,
Protocol: string(v1.ProtocolTCP),
}
endpts = append(endpts, &model.Endpoint{
Id: model.EndpointIdFromIPAddressAndPort(ip, endpointPort),
IP: ip,
ServicePort: model.Port{
Port: int32(servicePort),
TargetPort: portStr,
Protocol: model.TCPProtocol,
Protocol: string(v1.ProtocolTCP),
},
EndpointPort: endpointPort,
Attributes: make(map[string]string),
Expand Down
Loading