-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: update L1 CloudFormation resource definitions #33980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the L1 CloudFormation resource definitions with the latest changes from `@aws-cdk/aws-service-spec`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33980 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 120 120
Lines 6976 6976
Branches 1178 1178
=======================================
Hits 5859 5859
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Bedrock Knowledge Bases Updates haven't been picked up by this or previous updates. Could you check why? These properties have been available in CFN for at least 2 weeks. |
@pahud @paulhcsun could you please check for the request above from @aws-rafams ? Those missing properties are preventing users from building graphRag based scenarios through CDK |
CDK generates these changes automatically based on the publicly published schema once a week. CFN usually takes a couple of weeks to publicly publish the changes (even though it may be available in CFN, the schema itself takes longer to publish). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description only shows changes in documentation and addition of a few properties.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #33980 has been dequeued, merge conditions unmatch:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
@aws-rafams @krokoko
We need to update the patch to include these types manually. |
1. The issue building source model db, due to error importing "oneOf" union type, was fixed by #1666. 2. The patches prevent the CDK L1 to be updated automatically. After this fix, the modifications in Bedrock resources will automatically be applied to the CDK L1 constructs. This should address the concern from this comment: aws/aws-cdk#33980 (comment)
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Updates the L1 CloudFormation resource definitions with the latest changes from
@aws-cdk/aws-service-spec
L1 CloudFormation resource definition changes: