chore: make AwsClient#releaseResouces static #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyc-bq
approved these changes
Nov 26, 2024
karenc-bq
reviewed
Nov 26, 2024
karenc-bq
reviewed
Nov 26, 2024
sophia-bq
force-pushed
the
chore/make-releaseResouces-static
branch
from
cfd0145 to
55584bb
Compare
karenc-bq
approved these changes
Dec 2, 2024
sophia-bq
force-pushed
the
chore/make-releaseResouces-static
branch
from
55584bb to
c241a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update releaseResources to be a static method.
Description
Introduced a static set to track all the plugins in PluginManager that releases all resources when Client.end is called.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.